Changes to use URI instead of EntityId in internal APIs #1464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use await instead of a promise chain in Storage.syncCell. - Use URI isntead of Entity, since we also define this in memory/interface.ts.
…ll as the BaseStorageProvider implementation and the Storage class. Moved BaseStorageProvider.toEntity into Storage.toURI, since this is the only place it's needed. Changed IStorageProvider to use URI instead of EntityId, as well as the ProviderConnection and Provider classes. Updated tests to use cell.getAsNormalizedFullLink to get the URI instead of EntityId.
seefeldb
approved these changes
Jul 22, 2025
ubik2
added a commit
that referenced
this pull request
Jul 22, 2025
…c calls (#1463) * feat(runner): call sync directly when not in shim; allow URIs in .sync calls - Update storage.ts to call sync directly when not running in a shim environment. - Allow either EntityId or URIs on sync call (eventually we'll deprecate the former) * cleaner return value * Changes to use URI instead of EntityId in internal APIs (#1464) * Minor tweaks - Use await instead of a promise chain in Storage.syncCell. - Use URI isntead of Entity, since we also define this in memory/interface.ts. * Change IStorageProvider API to be URI based instead of EntityId as well as the BaseStorageProvider implementation and the Storage class. Moved BaseStorageProvider.toEntity into Storage.toURI, since this is the only place it's needed. Changed IStorageProvider to use URI instead of EntityId, as well as the ProviderConnection and Provider classes. Updated tests to use cell.getAsNormalizedFullLink to get the URI instead of EntityId. --------- Co-authored-by: ubik2 <ubik2@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Replaced a promise chain with async/await in Storage.syncCell and updated type usage from Entity to URI for consistency with memory/interface.ts.